Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #52

Merged
merged 22 commits into from
Apr 4, 2022
Merged

Dev #52

merged 22 commits into from
Apr 4, 2022

Conversation

Hu-JIN
Copy link
Collaborator

@Hu-JIN Hu-JIN commented Apr 4, 2022

No description provided.

dgulhan-bio and others added 22 commits April 2, 2022 15:07
Allow not providing signatures_catalog
To consistently use indices_associated_sigs.
Do not sort signatures. So that the returned signatures are the same as signatures, if signatures is complete, i.e., contains all connected signatures.
Now matching will always be performed with SparseNNLS with indices_associated_sigs set to None.

Then in the final W_s, we check what signatures are there, and add missing connected signatures if there are.

This is a better approach, because if we simply use indices_associated_sigs in SparseNNLS, then after _get_W_s() and _clear_W_s(), we may still lose connected signatures.
@Hu-JIN Hu-JIN merged commit c65c1a5 into main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants